Garry's Mod server help

[ibor10]

I followed a few tutorials on setting up a dedicated server on my computer, and i got most everything to work.. up till now. I have Gmod and nothing else installed onto the server and it launches fine, I log into steam and i can see the server when added to my favorites. Problem is no one else can, and when people try to join me through steam chat, my game info shows up as "Server is not Responding".

BASIC INFO
Server OS: Windows XP 2002
Processor: AMD Anthlon XP 3000+ 2.16 GHz
Ram: 1 GB
Game(s): Garry's Mod
Start Up Command: c:\srcds\orangebox\srcds.exe -console -game garrysmod +map gm_construct -maxplayers 16 -autoupdate
Admin Mods: None at the moment. Decided it best to try and get gmod running before trying anything else.

Here are the tuts i used:
https://support.steampowered.com/kb_article.php?ref=6758-TCMF-2234
http://wiki.garrysmod.com/?title=Dedicated_Server_Setup

Anything i'm doing wrong/not doing? Please help haha

---

Aight... A friend helped me fix it and people can join now. But it lags everyone to hell. =|

[Mooga]

You need to give them your EXTERNAL IP address. They will not be able to join via you because you are connected via the internal IP address. You also need to do portforwarding on the router.

[ibor10]

I had the port forwarding right, i was just giving out the wrong IP. thanks ^_^